From 308a7485f233ca23e1ed35d624af7800643df0d8 Mon Sep 17 00:00:00 2001
From: "Jack Boswell (boswelja)" <boswelja@outlook.com>
Date: Tue, 10 Nov 2020 18:44:09 +1300
Subject: [PATCH] Try using for/of instead of for/in

---
 lib/edits.js | 4 ++--
 lib/main.js  | 3 +--
 src/edits.ts | 4 ++--
 src/main.ts  | 3 +--
 4 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/lib/edits.js b/lib/edits.js
index 4709b179..69ee329b 100644
--- a/lib/edits.js
+++ b/lib/edits.js
@@ -40,7 +40,7 @@ function uploadToPlayStore(options, releaseFiles) {
         // Check the 'track' for 'internalsharing', if so switch to a non-track api
         if (options.track === 'internalsharing') {
             core.debug("Track is Internal app sharing, switch to special upload api");
-            for (const releaseFile in releaseFiles) {
+            for (const releaseFile of releaseFiles) {
                 core.debug(`Uploading ${releaseFile}`);
                 yield uploadInternalSharingRelease(options, releaseFile).catch(reason => {
                     core.setFailed(reason);
@@ -61,7 +61,7 @@ function uploadToPlayStore(options, releaseFiles) {
             });
             // Upload artifacts to Google Play, and store their version codes
             var versionCodes = new Array();
-            for (const releaseFile in releaseFiles) {
+            for (const releaseFile of releaseFiles) {
                 core.debug(`Uploading ${releaseFile}`);
                 const versionCode = yield uploadRelease(appEdit.data, options, releaseFile).catch(reason => {
                     core.setFailed(reason);
diff --git a/lib/main.js b/lib/main.js
index 8493b1bd..6c8cd1c7 100644
--- a/lib/main.js
+++ b/lib/main.js
@@ -76,8 +76,7 @@ function run() {
                 userFractionFloat = undefined;
             }
             // Check release files
-            core.debug(`Checking release files ${releaseFiles}`);
-            for (const releaseFile in releaseFiles) {
+            for (const releaseFile of releaseFiles) {
                 core.debug(`Validating ${releaseFile} exists`);
                 if (!fs.existsSync(releaseFile)) {
                     core.setFailed(`Unable to find release file @ ${releaseFile}`);
diff --git a/src/edits.ts b/src/edits.ts
index f3634291..7d65e414 100644
--- a/src/edits.ts
+++ b/src/edits.ts
@@ -31,7 +31,7 @@ export async function uploadToPlayStore(options: EditOptions, releaseFiles: stri
     // Check the 'track' for 'internalsharing', if so switch to a non-track api
     if (options.track === 'internalsharing') {
         core.debug("Track is Internal app sharing, switch to special upload api")
-        for (const releaseFile in releaseFiles) {
+        for (const releaseFile of releaseFiles) {
             core.debug(`Uploading ${releaseFile}`);
             await uploadInternalSharingRelease(options, releaseFile).catch(reason => {
                 core.setFailed(reason);
@@ -53,7 +53,7 @@ export async function uploadToPlayStore(options: EditOptions, releaseFiles: stri
 
         // Upload artifacts to Google Play, and store their version codes
         var versionCodes = new Array<number>();
-        for (const releaseFile in releaseFiles) {
+        for (const releaseFile of releaseFiles) {
             core.debug(`Uploading ${releaseFile}`);
             const versionCode = await uploadRelease(appEdit.data, options, releaseFile).catch(reason => {
                 core.setFailed(reason);
diff --git a/src/main.ts b/src/main.ts
index 0aa4343a..774316ee 100644
--- a/src/main.ts
+++ b/src/main.ts
@@ -52,8 +52,7 @@ async function run() {
         }
 
         // Check release files
-        core.debug(`Checking release files ${releaseFiles}`);
-        for (const releaseFile in releaseFiles) {
+        for (const releaseFile of releaseFiles) {
             core.debug(`Validating ${releaseFile} exists`)
             if (!fs.existsSync(releaseFile)) {
                 core.setFailed(`Unable to find release file @ ${releaseFile}`);