Fixed precondition checks for whatsnew and mapping files, to fix issues outlined in #2

This commit is contained in:
Drew Heavner
2019-12-12 08:50:26 -05:00
parent 3e0a7f808c
commit b6496ac4e3
5 changed files with 11 additions and 11 deletions

View File

@@ -100,7 +100,7 @@ function trackVersionCode(appEdit, options, versionCode) {
}
function readLocalizedReleaseNotes(whatsNewDir) {
return __awaiter(this, void 0, void 0, function* () {
if (whatsNewDir != undefined) {
if (whatsNewDir != undefined && whatsNewDir.length > 0) {
const releaseNotes = fs.readdirSync(whatsNewDir).filter(value => /whatsnew-*-*/.test(value));
const pattern = /whatsnew-(?<local>.*-.*)/.compile();
let localizedReleaseNotes = [];
@@ -125,7 +125,7 @@ function readLocalizedReleaseNotes(whatsNewDir) {
}
function uploadMappingFile(appEdit, versionCode, options) {
return __awaiter(this, void 0, void 0, function* () {
if (options.mappingFile != undefined) {
if (options.mappingFile != undefined && options.mappingFile.length > 0) {
const mapping = fs_1.readFileSync(options.mappingFile, 'utf-8');
if (mapping != undefined) {
core.debug(`[${appEdit.id}, versionCode=${versionCode}, packageName=${options.applicationId}]: Uploading Proguard mapping file @ ${options.mappingFile}`);

View File

@@ -48,11 +48,11 @@ function run() {
core.setFailed(`Unable to find release file @ ${releaseFile}`);
return;
}
if (whatsNewDir != undefined && !fs.existsSync(whatsNewDir)) {
if (whatsNewDir != undefined && whatsNewDir.length > 0 && !fs.existsSync(whatsNewDir)) {
core.setFailed(`Unable to find 'whatsnew' directory @ ${whatsNewDir}`);
return;
}
if (mappingFile != undefined && !fs.existsSync(mappingFile)) {
if (mappingFile != undefined && mappingFile.length > 0 && !fs.existsSync(mappingFile)) {
core.setFailed(`Unable to find 'mappingFile' @ ${mappingFile}`);
return;
}
@@ -67,7 +67,7 @@ function run() {
whatsNewDir: whatsNewDir,
mappingFile: mappingFile
}, releaseFile);
core.debug('Finished App Release!');
console.log(`Finished uploading ${releaseFile} to the Play Store`);
}
catch (error) {
core.setFailed(error.message);