From b88b48212e1363ac6c587d232676006925e49881 Mon Sep 17 00:00:00 2001 From: "Jack Boswell (boswelja)" Date: Thu, 5 Nov 2020 10:17:49 +1300 Subject: [PATCH] Fix artifact uploads possibly occurring after committing the edit --- src/edits.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/edits.ts b/src/edits.ts index 2f3d917d..11d7a77e 100644 --- a/src/edits.ts +++ b/src/edits.ts @@ -31,13 +31,13 @@ export async function uploadToPlayStore(options: EditOptions, releaseFiles: stri // Check the 'track' for 'internalsharing', if so switch to a non-track api if (options.track === 'internalsharing') { core.debug("Track is Internal app sharing, switch to special upload api") - releaseFiles.forEach(async releaseFile => { + for (const releaseFile in releaseFiles) { core.debug(`Uploading ${releaseFile}`); await uploadInternalSharingRelease(options, releaseFile).catch(reason => { core.setFailed(reason); return Promise.reject(reason); }); - }); + } } else { // Create a new Edit const appEdit = await androidPublisher.edits.insert({ @@ -53,14 +53,14 @@ export async function uploadToPlayStore(options: EditOptions, releaseFiles: stri // Upload artifacts to Google Play, and store their version codes var versionCodes = new Array(); - releaseFiles.forEach(async releaseFile => { + for (const releaseFile in releaseFiles) { core.debug(`Uploading ${releaseFile}`); const versionCode = await uploadRelease(appEdit.data, options, releaseFile).catch(reason => { core.setFailed(reason); return Promise.reject(reason); }); versionCodes.push(versionCode!); - }); + } // Add the uploaded artifacts to the Edit track const track = addReleasesToTrack(appEdit.data, options, versionCodes);