actions/upload-google-play
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove setFailed calls from functionsThese are handled in the catch block on each call in uploadToPlayStore

Browse Source
This commit is contained in:
Jack Boswell (boswelja)
2020-11-05 19:16:32 +13:00
parent d2ed26efd5
commit cdd4e28c71
2 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/edits.js
View File

@@ -103,7 +103,6 @@ function uploadInternalSharingRelease(options, releaseFile) {
return Promise.resolve(res.downloadUrl); return Promise.resolve(res.downloadUrl);
} }
else { else {
core.setFailed(`${releaseFile} is invalid`);
return Promise.reject(`${releaseFile} is invalid`); return Promise.reject(`${releaseFile} is invalid`);
} }
}); });
@@ -121,7 +120,6 @@ function uploadRelease(appEdit, options, releaseFile) {
return Promise.resolve(bundle.versionCode); return Promise.resolve(bundle.versionCode);
} }
else { else {
core.setFailed(`${releaseFile} is invalid`);
return Promise.reject(`${releaseFile} is invalid`); return Promise.reject(`${releaseFile} is invalid`);
} }
}); });
@@ -135,8 +133,7 @@ function validateSelectedTrack(appEdit, options) {
}); });
const allTracks = res.data.tracks; const allTracks = res.data.tracks;
if (allTracks == undefined || allTracks.find(value => value.track == options.track) == undefined) { if (allTracks == undefined || allTracks.find(value => value.track == options.track) == undefined) {
core.setFailed(`Track "${options.track}" could not be found `); return Promise.reject(`Track "${options.track}" could not be found `);
return Promise.reject(`No track found for "${options.track}"`);
} }
}); });
} }
@@ -163,7 +160,7 @@ function addReleasesToTrack(appEdit, options, versionCodes) {
userFraction: options.userFraction, userFraction: options.userFraction,
status: status, status: status,
releaseNotes: yield whatsnew_1.readLocalizedReleaseNotes(options.whatsNewDir), releaseNotes: yield whatsnew_1.readLocalizedReleaseNotes(options.whatsNewDir),
versionCodes: versionCodes.map(x => x.toString()) versionCodes: versionCodes.filter(x => x != 0).map(x => x.toString())
} }
] ]
} }

7
src/edits.ts
View File

@@ -93,7 +93,6 @@ async function uploadInternalSharingRelease(options: EditOptions, releaseFile: s
console.log(`${releaseFile} uploaded to Internal Sharing, download it with ${res.downloadUrl}`) console.log(`${releaseFile} uploaded to Internal Sharing, download it with ${res.downloadUrl}`)
return Promise.resolve(res.downloadUrl) return Promise.resolve(res.downloadUrl)
} else { } else {
core.setFailed(`${releaseFile} is invalid`)
return Promise.reject(`${releaseFile} is invalid`) return Promise.reject(`${releaseFile} is invalid`)
} }
} }
@@ -108,7 +107,6 @@ async function uploadRelease(appEdit: AppEdit, options: EditOptions, releaseFile
await uploadMappingFile(appEdit, bundle.versionCode!, options); await uploadMappingFile(appEdit, bundle.versionCode!, options);
return Promise.resolve(bundle.versionCode); return Promise.resolve(bundle.versionCode);
} else { } else {
core.setFailed(`${releaseFile} is invalid`);
return Promise.reject(`${releaseFile} is invalid`); return Promise.reject(`${releaseFile} is invalid`);
} }
} }
@@ -121,8 +119,7 @@ async function validateSelectedTrack(appEdit: AppEdit, options: EditOptions): Pr
}); });
const allTracks = res.data.tracks; const allTracks = res.data.tracks;
if (allTracks == undefined || allTracks.find(value => value.track == options.track) == undefined) { if (allTracks == undefined || allTracks.find(value => value.track == options.track) == undefined) {
core.setFailed(`Track "${options.track}" could not be found `); return Promise.reject(`Track "${options.track}" could not be found `);
return Promise.reject(`No track found for "${options.track}"`);
} }
} }
@@ -148,7 +145,7 @@ async function addReleasesToTrack(appEdit: AppEdit, options: EditOptions, versio
userFraction: options.userFraction, userFraction: options.userFraction,
status: status, status: status,
releaseNotes: await readLocalizedReleaseNotes(options.whatsNewDir), releaseNotes: await readLocalizedReleaseNotes(options.whatsNewDir),
versionCodes: versionCodes.map(x => x.toString()) versionCodes: versionCodes.filter(x => x != 0).map(x => x.toString())
} }
] ]
} }