actions/upload-google-play
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename trackVersionCode to addReleasesToTrack

Browse Source 
I feel this better describes what the function does
This commit is contained in:
Jack Boswell (boswelja)
2020-10-23 16:15:51 +13:00
parent fc19501036
commit 32ecfee315
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/edits.js
View File

@@ -54,7 +54,7 @@ function uploadToPlayStore(options, releaseFiles) {
});
versionCodes.push(versionCode);
}));
const track = trackVersionCode(appEdit.data, options, versionCodes);
const track = addReleasesToTrack(appEdit.data, options, versionCodes);
const res = yield androidPublisher.edits.commit({
auth: options.auth,
editId: appEdit.data.id,
@@ -121,7 +121,7 @@ function validateSelectedTrack(appEdit, options) {
}
});
}
function trackVersionCode(appEdit, options, versionCodes) {
function addReleasesToTrack(appEdit, options, versionCodes) {
return __awaiter(this, void 0, void 0, function* () {
let status;
if (options.userFraction != undefined) {

22
src/edits.ts
View File

@@ -48,7 +48,7 @@ export async function uploadToPlayStore(options: EditOptions, releaseFiles: stri
versionCodes.push(versionCode!);
});
const track = trackVersionCode(appEdit.data, options, versionCodes);
const track = addReleasesToTrack(appEdit.data, options, versionCodes);
const res = await androidPublisher.edits.commit({
auth: options.auth,
editId: appEdit.data.id!,
@@ -85,14 +85,14 @@ async function uploadRelease(appEdit: AppEdit, options: EditOptions, releaseFile
if (releaseFile.endsWith('.apk')) {
const apk = await uploadApk(appEdit, options, releaseFile);
await uploadMappingFile(appEdit, apk.versionCode!, options);
return Promise.resolve(apk.versionCode)
return Promise.resolve(apk.versionCode);
} else if (releaseFile.endsWith('.aab')) {
const bundle = await uploadBundle(appEdit, options, releaseFile);
await uploadMappingFile(appEdit, bundle.versionCode!, options);
return Promise.resolve(bundle.versionCode)
return Promise.resolve(bundle.versionCode);
} else {
core.setFailed(`${releaseFile} is invalid`)
return Promise.reject(`${releaseFile} is invalid`)
core.setFailed(`${releaseFile} is invalid`);
return Promise.reject(`${releaseFile} is invalid`);
}
}
@@ -104,17 +104,17 @@ async function validateSelectedTrack(appEdit: AppEdit, options: EditOptions): Pr
});
const allTracks = res.data.tracks;
if (allTracks == undefined || allTracks.find(value => value.track == options.track) == undefined) {
core.setFailed(`Track "${options.track}" could not be found `)
return Promise.reject(`No track found for "${options.track}"`)
core.setFailed(`Track "${options.track}" could not be found `);
return Promise.reject(`No track found for "${options.track}"`);
}
}
async function trackVersionCode(appEdit: AppEdit, options: EditOptions, versionCodes: number[]): Promise<Track> {
async function addReleasesToTrack(appEdit: AppEdit, options: EditOptions, versionCodes: number[]): Promise<Track> {
let status: string;
if (options.userFraction != undefined) {
status = 'inProgress'
status = 'inProgress';
} else {
status = 'completed'
status = 'completed';
}
core.debug(`Creating Track Release for Edit(${appEdit.id}) for Track(${options.track}) with a UserFraction(${options.userFraction}) and VersionCodes(${versionCodes})`);
@@ -137,7 +137,7 @@ async function trackVersionCode(appEdit: AppEdit, options: EditOptions, versionC
}
});
return res.data
return res.data;
}
async function uploadMappingFile(appEdit: AppEdit, versionCode: number, options: EditOptions) {