Fix issues parsing Int and Float (#145)
Undefined was transformed into NaN, which is not undefined and thus failed validation
This commit is contained in:
File diff suppressed because one or more lines are too long
@@ -24,7 +24,7 @@ export interface EditOptions {
|
||||
applicationId: string;
|
||||
track: string;
|
||||
inAppUpdatePriority: number;
|
||||
userFraction: number;
|
||||
userFraction?: number;
|
||||
whatsNewDir?: string;
|
||||
mappingFile?: string;
|
||||
debugSymbols?: string;
|
||||
|
||||
14
src/main.ts
14
src/main.ts
@@ -33,14 +33,24 @@ async function run() {
|
||||
await validateServiceAccountJson(serviceAccountJsonRaw, serviceAccountJson)
|
||||
|
||||
// Validate user fraction
|
||||
const userFractionFloat = parseFloat(userFraction)
|
||||
let userFractionFloat: number | undefined
|
||||
if (userFraction) {
|
||||
userFractionFloat = parseFloat(userFraction)
|
||||
} else {
|
||||
userFractionFloat = undefined
|
||||
}
|
||||
await validateUserFraction(userFractionFloat)
|
||||
|
||||
// Validate release status
|
||||
await validateStatus(status, userFraction != undefined)
|
||||
|
||||
// Validate the inAppUpdatePriority to be a valid number in within [0, 5]
|
||||
const inAppUpdatePriorityInt: number | undefined = parseInt(inAppUpdatePriority);
|
||||
let inAppUpdatePriorityInt: number | undefined
|
||||
if (inAppUpdatePriority) {
|
||||
inAppUpdatePriorityInt = parseInt(inAppUpdatePriority)
|
||||
} else {
|
||||
inAppUpdatePriorityInt = undefined
|
||||
}
|
||||
await validateInAppUpdatePriority(inAppUpdatePriorityInt)
|
||||
|
||||
// Check release files while maintaining backward compatibility
|
||||
|
||||
Reference in New Issue
Block a user