Fix issues parsing Int and Float (#145)

Undefined was transformed into NaN, which is not undefined and thus failed validation
This commit is contained in:
Jack Boswell
2022-09-24 16:51:04 +12:00
committed by GitHub
parent 7cd1379b4f
commit 99b7a1e1d4
3 changed files with 14 additions and 4 deletions

File diff suppressed because one or more lines are too long

View File

@@ -24,7 +24,7 @@ export interface EditOptions {
applicationId: string;
track: string;
inAppUpdatePriority: number;
userFraction: number;
userFraction?: number;
whatsNewDir?: string;
mappingFile?: string;
debugSymbols?: string;

View File

@@ -33,14 +33,24 @@ async function run() {
await validateServiceAccountJson(serviceAccountJsonRaw, serviceAccountJson)
// Validate user fraction
const userFractionFloat = parseFloat(userFraction)
let userFractionFloat: number | undefined
if (userFraction) {
userFractionFloat = parseFloat(userFraction)
} else {
userFractionFloat = undefined
}
await validateUserFraction(userFractionFloat)
// Validate release status
await validateStatus(status, userFraction != undefined)
// Validate the inAppUpdatePriority to be a valid number in within [0, 5]
const inAppUpdatePriorityInt: number | undefined = parseInt(inAppUpdatePriority);
let inAppUpdatePriorityInt: number | undefined
if (inAppUpdatePriority) {
inAppUpdatePriorityInt = parseInt(inAppUpdatePriority)
} else {
inAppUpdatePriorityInt = undefined
}
await validateInAppUpdatePriority(inAppUpdatePriorityInt)
// Check release files while maintaining backward compatibility