feature: Add support for changesNotSentForReview (#117)

Credits to @princefr for the original implementation
This commit is contained in:
Jack Boswell
2022-06-18 19:50:39 +12:00
committed by GitHub
parent 7f42989517
commit e00bb8ce1e
5 changed files with 12 additions and 3 deletions

View File

@@ -16,6 +16,7 @@ This action will help you upload an Android `.apk` or `.aab` (Android App Bundle
| status | Release status. This can be set to `draft` to complete the release at some other time. Defaults to `completed` if targeting 100% rollout, else `inProgress` | One of `completed`, `inProgress`, `halted`, `draft` | false |
| whatsNewDirectory | The directory of localized "whats new" files to upload as the release notes. The files contained in the `whatsNewDirectory` MUST use the pattern `whatsnew-<LOCALE>` where `LOCALE` is using the [`BCP 47`](https://tools.ietf.org/html/bcp47) format | A path to a valid `whatsNewDirectory` | false |
| mappingFile | The mapping.txt file used to de-obfuscate your stack traces from crash reports | A path to a valid `mapping.txt` file | false |
| changesNotSentForReview | Indicates that the changes in this edit will not be reviewed until they are explicitly sent for review from the Google Play Console. Defaults to `false` | `true` or `false` | `false` |
| serviceAccountJson | The service account json private key file to authorize the upload request. Can be used instead of `serviceAccountJsonPlainText` to specify a file rather than provide a secret | A path to a valid `service-account.json` file | true (or serviceAccountJsonPlainText) |
| ~~releaseFile~~ | Please switch to using `releaseFiles` as this will be removed in the future | | false |

View File

@@ -43,6 +43,10 @@ inputs:
mappingFile:
description: "The mapping.txt file used to de-obfuscate your stack traces from crash reports"
required: false
changesNotSentForReview:
description: "Indicates that the changes in this edit will not be reviewed until they are explicitly sent for review from the Google Play Console"
default: false
required: false
outputs:
internalSharingDownloadUrl:
description: "The internal app sharing download url if track was 'internalsharing'"

File diff suppressed because one or more lines are too long

View File

@@ -27,6 +27,7 @@ export interface EditOptions {
mappingFile?: string;
name?: string;
status?: string;
changesNotSentForReview?: boolean;
}
export async function uploadToPlayStore(options: EditOptions, releaseFiles: string[]): Promise<string | undefined> {
@@ -84,7 +85,8 @@ export async function uploadToPlayStore(options: EditOptions, releaseFiles: stri
const res = await androidPublisher.edits.commit({
auth: options.auth,
editId: appEdit.data.id!,
packageName: options.applicationId
packageName: options.applicationId,
changesNotSentForReview: options.changesNotSentForReview
});
// Simple check to see whether commit was successful

View File

@@ -24,6 +24,7 @@ async function run() {
const status = core.getInput('status', { required: false });
const whatsNewDir = core.getInput('whatsNewDirectory', { required: false });
const mappingFile = core.getInput('mappingFile', { required: false });
const changesNotSentForReview = core.getInput('changesNotSentForReview', { required: false }) == 'true';
// Validate that we have a service account json in some format
if (!serviceAccountJson && !serviceAccountJsonRaw) {
@@ -116,7 +117,8 @@ async function run() {
status: status,
whatsNewDir: whatsNewDir,
mappingFile: mappingFile,
name: releaseName
name: releaseName,
changesNotSentForReview: changesNotSentForReview
}, validatedReleaseFiles);
console.log(`Finished uploading to the Play Store: ${result}`)