Add an upload timeout of 60 minutes (#171 )

* Add an upload timeout of 60 minutes * Remove now defunct tests
Remove status default from README (#164 )
2023-02-10 22:59:20 +13:00 · 2023-02-10 22:00:07 +13:00 · 2023-01-13 16:55:12 +13:00 · 2023-01-13 15:31:31 +13:00 · 2023-01-13 15:25:47 +13:00 · 2022-12-07 15:19:47 +13:00
9 changed files with 193 additions and 289 deletions
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -1,24 +1,16 @@
-name: "Tag & Deploy Action"
+name: "Update v1 tag"

 on:
-  push:
-    branches:
-      - master
+  release:
+    types: [released]

 jobs:
  release:
    runs-on: ubuntu-latest
    steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v2.5.0

-    - name: Install
-      run: npm ci
-
-    - name: Run Tests
-      run: npm run test
-
-    - name: Update v1 Tag
-      uses: hole19/git-tag-action@master
-      env:
-        TAG: v1
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    - uses: rickstaa/action-create-tag@v1
+      with:
+        tag: v1
+        force_push_tag: true
--- a/README.md
+++ b/README.md
@@ -8,12 +8,12 @@ This action will help you upload an Android `.apk` or `.aab` (Android App Bundle
 | --- | --- | --- | --- |
 | releaseFiles | The Android release file(s) to upload (.apk or .aab) | Comma-separated paths. Supports glob via [fast-glob](https://github.com/mrmlnc/fast-glob) | true |
 | serviceAccountJsonPlainText | The service account json in plain text, provided via a secret, etc | The contents of your `service-account.json` | true (or serviceAccountJson) |
-| packageName | The package name, or Application Id, of the app you are uploading | A valid package name, e.g. `com.example.myapp` | true |
+| packageName | The package name, or Application Id, of the app you are uploading | A valid package name, e.g. `com.example.myapp`. The packageName must already exist in the play console account, so make sure you upload a manual apk or aab first through the console | true |
 | track | The track in which you want to assign the uploaded app. Defaults to `production` | One of `production`, `beta`, `alpha`, `internalsharing`, `internal`, or a custom track name (case sensitive) | true |
 | releaseName | The release name. Not required to be unique. Default is configured by Google Play Console | A user-friendly update name, e.g. `v1.0.0` | false |
 | inAppUpdatePriority | In-app update priority of the release. All newly added APKs in the release will be considered at this priority. Defaults to `0` | `[0-5]`, where `5` is the highest priority | false |
-| userFraction | Percentage of users who should get the staged version of the app. Defaults to `1.0` | `[0.0-1.0]` | true |
-| status | Release status. Defaults to `completed` if targeting 100% rollout, `halted` for 0%, and `inProgress` for anything in between | One of `completed`, `inProgress`, `halted`, `draft` | false |
+| userFraction | Percentage of users who should get the staged version of the app. | `(0.0-1.0)` | false |
+| status | Release status. Defaults to `completed`. | One of `completed`, `inProgress`, `halted`, `draft`. Cannot be null. | false |
 | whatsNewDirectory | The directory of localized "whats new" files to upload as the release notes. The files contained in the `whatsNewDirectory` MUST use the pattern `whatsnew-<LOCALE>` where `LOCALE` is using the [`BCP 47`](https://tools.ietf.org/html/bcp47) format | A path to a valid `whatsNewDirectory` | false |
 | mappingFile | The mapping.txt file used to de-obfuscate your stack traces from crash reports | A path to a valid `mapping.txt` file | false |
 | debugSymbols | The native-debug-symbols.zip file or folder that contains your debug symbols | A path to a valid `native-debug-symbols.zip file` file or a folder | false |
@@ -48,6 +48,10 @@ with:
  debugSymbols: app/intermediates/merged_native_libs/release/out/lib
 ```

+## FAQ
+### I get the error "Package not found"
+Make sure you upload an apk or aab manually first by creating a release through the play console.
+
 The `whatsNewDirectory` in this example supplies changelogs for English, German and Japanese

 ```
--- a/tests/main.test.ts
+++ b/tests/main.test.ts
@@ -1,98 +0,0 @@
-import {RunOptions, RunTarget} from 'github-action-ts-run-api';
-
-const target = RunTarget.mainJs('action.yml');
-
-async function expectRunInitiatesUpload(options: RunOptions) {
-    const result = await target.run(options)
-    expect(result.commands.errors.length).toBe(1)
-    expect(result.commands.errors).toContainEqual("The incoming JSON object does not contain a client_email field")
-}
-
-test("correct inputs for complete rollout", async () => {
-    // Run with the bare minimum
-    const minimumOptions = RunOptions.create()
-        .setInputs({
-            serviceAccountJsonPlainText: "{}",
-            packageName: "com.package.name",
-            releaseFiles: "./__tests__/releasefiles/*.aab",
-            track: "production",
-            status: "completed",
-        })
-    await expectRunInitiatesUpload(minimumOptions)
-
-    // Test with optional extras
-    const extraOptions = RunOptions.create()
-        .setInputs({
-            serviceAccountJsonPlainText: "{}",
-            packageName: "com.package.name",
-            releaseFiles: "./__tests__/releasefiles/*.aab",
-            releaseName: "Release name",
-            track: "production",
-            inAppUpdatePriority: "3",
-            status: "completed",
-            whatsNewDir: "./__tests__/whatsnew",
-            changesNotSentForReview: "true",
-            existingEditId: "123"
-        })
-        await expectRunInitiatesUpload(extraOptions)
-    })
-
-test("correct inputs for inProgress rollout", async () => {
-    // Run with the bare minimum
-    const minimumOptions = RunOptions.create()
-        .setInputs({
-            serviceAccountJsonPlainText: "{}",
-            packageName: "com.package.name",
-            releaseFiles: "./__tests__/releasefiles/*.aab",
-            track: "production",
-            userFraction: "0.99",
-            status: "inProgress",
-        })
-        await expectRunInitiatesUpload(minimumOptions)
-
-    // Test with optional extras
-    const extraOptions = RunOptions.create()
-        .setInputs({
-            serviceAccountJsonPlainText: "{}",
-            packageName: "com.package.name",
-            releaseFiles: "./__tests__/releasefiles/*.aab",
-            releaseName: "Release name",
-            track: "production",
-            inAppUpdatePriority: "3",
-            userFraction: "0.5",
-            status: "inProgress",
-            whatsNewDir: "./__tests__/whatsnew",
-            changesNotSentForReview: "true",
-            existingEditId: "123"
-        })
-        await expectRunInitiatesUpload(extraOptions)
-})
-
-test("correct inputs for draft rollout", async () => {
-    // Run with the bare minimum
-    const minimumOptions = RunOptions.create()
-        .setInputs({
-            serviceAccountJsonPlainText: "{}",
-            packageName: "com.package.name",
-            releaseFiles: "./__tests__/releasefiles/*.aab",
-            track: "production",
-            status: "draft",
-        })
-        await expectRunInitiatesUpload(minimumOptions)
-
-    // Test with optional extras
-    const extraOptions = RunOptions.create()
-        .setInputs({
-            serviceAccountJsonPlainText: "{}",
-            packageName: "com.package.name",
-            releaseFiles: "./__tests__/releasefiles/*.aab",
-            releaseName: "Release name",
-            track: "production",
-            inAppUpdatePriority: "3",
-            status: "draft",
-            whatsNewDir: "./__tests__/whatsnew",
-            changesNotSentForReview: "true",
-            existingEditId: "123"
-        })
-        await expectRunInitiatesUpload(extraOptions)
-    })
--- a/action.yml
+++ b/action.yml
@@ -36,7 +36,8 @@ inputs:
    required: false
  status:
    description: "Release status. This can be set to 'draft' to complete the release at some other time."
-    required: false
+    required: true
+    default: "completed"
  whatsNewDirectory:
    description: "The directory of localized whats new files"
    required: false
--- a/lib/index.js
+++ b/lib/index.js
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,16 +1,16 @@
 {
  "name": "upload-google-play",
-  "version": "1.0.19",
+  "version": "1.1.0",
  "lockfileVersion": 2,
  "requires": true,
  "packages": {
    "": {
      "name": "upload-google-play",
-      "version": "1.0.19",
+      "version": "1.1.0",
      "license": "MIT",
      "dependencies": {
        "@actions/core": "^1.10.0",
-        "@googleapis/androidpublisher": "^3.0.0",
+        "@googleapis/androidpublisher": "^4.1.0",
        "fast-glob": "^3.2.12",
        "jszip": "^3.10.1"
      },
@@ -19,7 +19,7 @@
        "@types/node": "^18.11.4",
        "@typescript-eslint/eslint-plugin": "^5.40.1",
        "@typescript-eslint/parser": "^5.40.1",
-        "@vercel/ncc": "^0.34.0",
+        "@vercel/ncc": "^0.36.1",
        "eslint": "^8.26.0",
        "github-action-ts-run-api": "^2.2.2",
        "jest": "^29.2.1",
@@ -685,14 +685,14 @@
      }
    },
    "node_modules/@googleapis/androidpublisher": {
-      "version": "3.0.0",
-      "resolved": "https://registry.npmjs.org/@googleapis/androidpublisher/-/androidpublisher-3.0.0.tgz",
-      "integrity": "sha512-r4JfmLlcu/VI4hObZuQ8RW5OeWRFtOxqE9xU8C2GAp3GTu2ZcemEICu69xy/rchpzMNQY4lrr8WiqUG1LE1L5Q==",
+      "version": "4.1.0",
+      "resolved": "https://registry.npmjs.org/@googleapis/androidpublisher/-/androidpublisher-4.1.0.tgz",
+      "integrity": "sha512-u2xJHk+TzaD29hyBrry3XIfS8+5WsH5KVVSPbf68W9OG0gc6mXPTyUrCIDFKYQS/0VxlaJfnI1waBhWN7nM5dw==",
      "dependencies": {
-        "googleapis-common": "^5.0.1"
+        "googleapis-common": "^6.0.3"
      },
      "engines": {
-        "node": ">=10.0.0"
+        "node": ">=12.0.0"
      }
    },
    "node_modules/@humanwhocodes/config-array": {
@@ -1644,25 +1644,14 @@
      }
    },
    "node_modules/@vercel/ncc": {
-      "version": "0.34.0",
-      "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.34.0.tgz",
-      "integrity": "sha512-G9h5ZLBJ/V57Ou9vz5hI8pda/YQX5HQszCs3AmIus3XzsmRn/0Ptic5otD3xVST8QLKk7AMk7AqpsyQGN7MZ9A==",
+      "version": "0.36.1",
+      "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.36.1.tgz",
+      "integrity": "sha512-S4cL7Taa9yb5qbv+6wLgiKVZ03Qfkc4jGRuiUQMQ8HGBD5pcNRnHeYM33zBvJE4/zJGjJJ8GScB+WmTsn9mORw==",
      "dev": true,
      "bin": {
        "ncc": "dist/ncc/cli.js"
      }
    },
-    "node_modules/abort-controller": {
-      "version": "3.0.0",
-      "resolved": "https://registry.npmjs.org/abort-controller/-/abort-controller-3.0.0.tgz",
-      "integrity": "sha512-h8lQ8tacZYnR3vNQTgibj+tODHI5/+l06Au2Pcriv/Gmet0eaj4TwWH41sO9wnHDiQsEj19q0drzdWdeAHtweg==",
-      "dependencies": {
-        "event-target-shim": "^5.0.0"
-      },
-      "engines": {
-        "node": ">=6.5"
-      }
-    },
    "node_modules/acorn": {
      "version": "8.8.0",
      "resolved": "https://registry.npmjs.org/acorn/-/acorn-8.8.0.tgz",
@@ -1930,9 +1919,9 @@
      "dev": true
    },
    "node_modules/bignumber.js": {
-      "version": "9.1.0",
-      "resolved": "https://registry.npmjs.org/bignumber.js/-/bignumber.js-9.1.0.tgz",
-      "integrity": "sha512-4LwHK4nfDOraBCtst+wOWIHbu1vhvAPJK8g8nROd4iuc3PSEjWif/qwbkh8jwCJz6yDBvtU4KPynETgrfh7y3A==",
+      "version": "9.1.1",
+      "resolved": "https://registry.npmjs.org/bignumber.js/-/bignumber.js-9.1.1.tgz",
+      "integrity": "sha512-pHm4LsMJ6lzgNGVfZHjMoO8sdoRhOzOH4MLmY65Jg70bpxCKu5iOHNJyfF6OyvYw7t8Fpf35RuzUyqnQsj8Vig==",
      "engines": {
        "node": "*"
      }
@@ -2553,14 +2542,6 @@
        "node": ">=0.10.0"
      }
    },
-    "node_modules/event-target-shim": {
-      "version": "5.0.1",
-      "resolved": "https://registry.npmjs.org/event-target-shim/-/event-target-shim-5.0.1.tgz",
-      "integrity": "sha512-i/2XbnSz/uxRCU6+NdVJgKWDTM427+MqYbkQzD321DuCQJUqOuJKIA0IM2+W2xtYHdKOmZ4dR6fExsd4SXL+WQ==",
-      "engines": {
-        "node": ">=6"
-      }
-    },
    "node_modules/execa": {
      "version": "5.1.1",
      "resolved": "https://registry.npmjs.org/execa/-/execa-5.1.1.tgz",
@@ -2778,30 +2759,29 @@
      "integrity": "sha512-yIovAzMX49sF8Yl58fSCWJ5svSLuaibPxXQJFLmBObTuCr0Mf1KiPopGM9NiFjiYBCbfaa2Fh6breQ6ANVTI0A=="
    },
    "node_modules/gaxios": {
-      "version": "4.3.3",
-      "resolved": "https://registry.npmjs.org/gaxios/-/gaxios-4.3.3.tgz",
-      "integrity": "sha512-gSaYYIO1Y3wUtdfHmjDUZ8LWaxJQpiavzbF5Kq53akSzvmVg0RfyOcFDbO1KJ/KCGRFz2qG+lS81F0nkr7cRJA==",
+      "version": "5.0.2",
+      "resolved": "https://registry.npmjs.org/gaxios/-/gaxios-5.0.2.tgz",
+      "integrity": "sha512-TjtV2AJOZoMQqRYoy5eM8cCQogYwazWNYLQ72QB0kwa6vHHruYkGmhhyrlzbmgNHK1dNnuP2WSH81urfzyN2Og==",
      "dependencies": {
-        "abort-controller": "^3.0.0",
        "extend": "^3.0.2",
        "https-proxy-agent": "^5.0.0",
        "is-stream": "^2.0.0",
        "node-fetch": "^2.6.7"
      },
      "engines": {
-        "node": ">=10"
+        "node": ">=12"
      }
    },
    "node_modules/gcp-metadata": {
-      "version": "4.3.1",
-      "resolved": "https://registry.npmjs.org/gcp-metadata/-/gcp-metadata-4.3.1.tgz",
-      "integrity": "sha512-x850LS5N7V1F3UcV7PoupzGsyD6iVwTVvsh3tbXfkctZnBnjW5yu5z1/3k3SehF7TyoTIe78rJs02GMMy+LF+A==",
+      "version": "5.2.0",
+      "resolved": "https://registry.npmjs.org/gcp-metadata/-/gcp-metadata-5.2.0.tgz",
+      "integrity": "sha512-aFhhvvNycky2QyhG+dcfEdHBF0FRbYcf39s6WNHUDysKSrbJ5vuFbjydxBcmewtXeV248GP8dWT3ByPNxsyHCw==",
      "dependencies": {
-        "gaxios": "^4.0.0",
+        "gaxios": "^5.0.0",
        "json-bigint": "^1.0.0"
      },
      "engines": {
-        "node": ">=10"
+        "node": ">=12"
      }
    },
    "node_modules/gensync": {
@@ -2823,9 +2803,9 @@
      }
    },
    "node_modules/get-intrinsic": {
-      "version": "1.1.3",
-      "resolved": "https://registry.npmjs.org/get-intrinsic/-/get-intrinsic-1.1.3.tgz",
-      "integrity": "sha512-QJVz1Tj7MS099PevUG5jvnt9tSkXN8K14dxQlikJuPt4uD9hHAHjLyLBiLR5zELelBdD9QNRAXZzsJx0WaDL9A==",
+      "version": "1.2.0",
+      "resolved": "https://registry.npmjs.org/get-intrinsic/-/get-intrinsic-1.2.0.tgz",
+      "integrity": "sha512-L049y6nFOuom5wGyRc3/gdTLO94dySVKRACj1RmJZBQXlbTMhtNIgkWkUHq+jYmZvKf14EW1EoJnnjbmoHij0Q==",
      "dependencies": {
        "function-bind": "^1.1.1",
        "has": "^1.0.3",
@@ -2939,28 +2919,28 @@
      }
    },
    "node_modules/google-auth-library": {
-      "version": "7.14.1",
-      "resolved": "https://registry.npmjs.org/google-auth-library/-/google-auth-library-7.14.1.tgz",
-      "integrity": "sha512-5Rk7iLNDFhFeBYc3s8l1CqzbEBcdhwR193RlD4vSNFajIcINKI8W8P0JLmBpwymHqqWbX34pJDQu39cSy/6RsA==",
+      "version": "8.7.0",
+      "resolved": "https://registry.npmjs.org/google-auth-library/-/google-auth-library-8.7.0.tgz",
+      "integrity": "sha512-1M0NG5VDIvJZEnstHbRdckLZESoJwguinwN8Dhae0j2ZKIQFIV63zxm6Fo6nM4xkgqUr2bbMtV5Dgo+Hy6oo0Q==",
      "dependencies": {
        "arrify": "^2.0.0",
        "base64-js": "^1.3.0",
        "ecdsa-sig-formatter": "^1.0.11",
        "fast-text-encoding": "^1.0.0",
-        "gaxios": "^4.0.0",
-        "gcp-metadata": "^4.2.0",
-        "gtoken": "^5.0.4",
+        "gaxios": "^5.0.0",
+        "gcp-metadata": "^5.0.0",
+        "gtoken": "^6.1.0",
        "jws": "^4.0.0",
        "lru-cache": "^6.0.0"
      },
      "engines": {
-        "node": ">=10"
+        "node": ">=12"
      }
    },
    "node_modules/google-p12-pem": {
-      "version": "3.1.4",
-      "resolved": "https://registry.npmjs.org/google-p12-pem/-/google-p12-pem-3.1.4.tgz",
-      "integrity": "sha512-HHuHmkLgwjdmVRngf5+gSmpkyaRI6QmOg77J8tkNBHhNEI62sGHyw4/+UkgyZEI7h84NbWprXDJ+sa3xOYFvTg==",
+      "version": "4.0.1",
+      "resolved": "https://registry.npmjs.org/google-p12-pem/-/google-p12-pem-4.0.1.tgz",
+      "integrity": "sha512-WPkN4yGtz05WZ5EhtlxNDWPhC4JIic6G8ePitwUWy4l+XPVYec+a0j0Ts47PDtW59y3RwAhUd9/h9ZZ63px6RQ==",
      "dependencies": {
        "node-forge": "^1.3.1"
      },
@@ -2968,23 +2948,31 @@
        "gp12-pem": "build/src/bin/gp12-pem.js"
      },
      "engines": {
-        "node": ">=10"
+        "node": ">=12.0.0"
      }
    },
    "node_modules/googleapis-common": {
-      "version": "5.1.0",
-      "resolved": "https://registry.npmjs.org/googleapis-common/-/googleapis-common-5.1.0.tgz",
-      "integrity": "sha512-RXrif+Gzhq1QAzfjxulbGvAY3FPj8zq/CYcvgjzDbaBNCD6bUl+86I7mUs4DKWHGruuK26ijjR/eDpWIDgNROA==",
+      "version": "6.0.4",
+      "resolved": "https://registry.npmjs.org/googleapis-common/-/googleapis-common-6.0.4.tgz",
+      "integrity": "sha512-m4ErxGE8unR1z0VajT6AYk3s6a9gIMM6EkDZfkPnES8joeOlEtFEJeF8IyZkb0tjPXkktUfYrE4b3Li1DNyOwA==",
      "dependencies": {
        "extend": "^3.0.2",
-        "gaxios": "^4.0.0",
-        "google-auth-library": "^7.14.0",
+        "gaxios": "^5.0.1",
+        "google-auth-library": "^8.0.2",
        "qs": "^6.7.0",
        "url-template": "^2.0.8",
-        "uuid": "^8.0.0"
+        "uuid": "^9.0.0"
      },
      "engines": {
-        "node": ">=10.10.0"
+        "node": ">=12.0.0"
+      }
+    },
+    "node_modules/googleapis-common/node_modules/uuid": {
+      "version": "9.0.0",
+      "resolved": "https://registry.npmjs.org/uuid/-/uuid-9.0.0.tgz",
+      "integrity": "sha512-MXcSTerfPa4uqyzStbRoTgt5XIe3x5+42+q1sDuy3R5MDk66URdLMOZe5aPX/SQd+kuYAh0FdP/pO28IkQyTeg==",
+      "bin": {
+        "uuid": "dist/bin/uuid"
      }
    },
    "node_modules/graceful-fs": {
@@ -3000,16 +2988,16 @@
      "dev": true
    },
    "node_modules/gtoken": {
-      "version": "5.3.2",
-      "resolved": "https://registry.npmjs.org/gtoken/-/gtoken-5.3.2.tgz",
-      "integrity": "sha512-gkvEKREW7dXWF8NV8pVrKfW7WqReAmjjkMBh6lNCCGOM4ucS0r0YyXXl0r/9Yj8wcW/32ISkfc8h5mPTDbtifQ==",
+      "version": "6.1.2",
+      "resolved": "https://registry.npmjs.org/gtoken/-/gtoken-6.1.2.tgz",
+      "integrity": "sha512-4ccGpzz7YAr7lxrT2neugmXQ3hP9ho2gcaityLVkiUecAiwiy60Ii8gRbZeOsXV19fYaRjgBSshs8kXw+NKCPQ==",
      "dependencies": {
-        "gaxios": "^4.0.0",
-        "google-p12-pem": "^3.1.3",
+        "gaxios": "^5.0.1",
+        "google-p12-pem": "^4.0.0",
        "jws": "^4.0.0"
      },
      "engines": {
-        "node": ">=10"
+        "node": ">=12.0.0"
      }
    },
    "node_modules/has": {
@@ -3951,9 +3939,9 @@
      "dev": true
    },
    "node_modules/json5": {
-      "version": "2.2.1",
-      "resolved": "https://registry.npmjs.org/json5/-/json5-2.2.1.tgz",
-      "integrity": "sha512-1hqLFMSrGHRHxav9q9gNjJ5EXznIxGVO09xQRrwplcS8qs28pZ8s8hupZAmqDwZUmVZ2Qb2jnyPOWcDH8m8dlA==",
+      "version": "2.2.3",
+      "resolved": "https://registry.npmjs.org/json5/-/json5-2.2.3.tgz",
+      "integrity": "sha512-XmOWe7eyHYH14cLdVPoyg+GOH3rYX++KpzrylJwSW98t3Nk+U8XOl8FWKOgwtzdb8lXGf6zYwDUzeHMWfxasyg==",
      "dev": true,
      "bin": {
        "json5": "lib/cli.js"
@@ -4312,9 +4300,9 @@
      }
    },
    "node_modules/object-inspect": {
-      "version": "1.12.2",
-      "resolved": "https://registry.npmjs.org/object-inspect/-/object-inspect-1.12.2.tgz",
-      "integrity": "sha512-z+cPxW0QGUp0mcqcsgQyLVRDoXFQbXOwBaqyF7VIgI4TWNQsDHrBpUQslRmIfAoYWdYzs6UlKJtB2XJpTaNSpQ==",
+      "version": "1.12.3",
+      "resolved": "https://registry.npmjs.org/object-inspect/-/object-inspect-1.12.3.tgz",
+      "integrity": "sha512-geUvdk7c+eizMNUDkRpW1wJwgfOiOeHbxBR/hLXK1aT6zmVSO0jsQcs7fj6MGw89jC/cjGfLcNOrtMYtGqm81g==",
      "funding": {
        "url": "https://github.com/sponsors/ljharb"
      }
@@ -6045,11 +6033,11 @@
      }
    },
    "@googleapis/androidpublisher": {
-      "version": "3.0.0",
-      "resolved": "https://registry.npmjs.org/@googleapis/androidpublisher/-/androidpublisher-3.0.0.tgz",
-      "integrity": "sha512-r4JfmLlcu/VI4hObZuQ8RW5OeWRFtOxqE9xU8C2GAp3GTu2ZcemEICu69xy/rchpzMNQY4lrr8WiqUG1LE1L5Q==",
+      "version": "4.1.0",
+      "resolved": "https://registry.npmjs.org/@googleapis/androidpublisher/-/androidpublisher-4.1.0.tgz",
+      "integrity": "sha512-u2xJHk+TzaD29hyBrry3XIfS8+5WsH5KVVSPbf68W9OG0gc6mXPTyUrCIDFKYQS/0VxlaJfnI1waBhWN7nM5dw==",
      "requires": {
-        "googleapis-common": "^5.0.1"
+        "googleapis-common": "^6.0.3"
      }
    },
    "@humanwhocodes/config-array": {
@@ -6795,19 +6783,11 @@
      }
    },
    "@vercel/ncc": {
-      "version": "0.34.0",
-      "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.34.0.tgz",
-      "integrity": "sha512-G9h5ZLBJ/V57Ou9vz5hI8pda/YQX5HQszCs3AmIus3XzsmRn/0Ptic5otD3xVST8QLKk7AMk7AqpsyQGN7MZ9A==",
+      "version": "0.36.1",
+      "resolved": "https://registry.npmjs.org/@vercel/ncc/-/ncc-0.36.1.tgz",
+      "integrity": "sha512-S4cL7Taa9yb5qbv+6wLgiKVZ03Qfkc4jGRuiUQMQ8HGBD5pcNRnHeYM33zBvJE4/zJGjJJ8GScB+WmTsn9mORw==",
      "dev": true
    },
-    "abort-controller": {
-      "version": "3.0.0",
-      "resolved": "https://registry.npmjs.org/abort-controller/-/abort-controller-3.0.0.tgz",
-      "integrity": "sha512-h8lQ8tacZYnR3vNQTgibj+tODHI5/+l06Au2Pcriv/Gmet0eaj4TwWH41sO9wnHDiQsEj19q0drzdWdeAHtweg==",
-      "requires": {
-        "event-target-shim": "^5.0.0"
-      }
-    },
    "acorn": {
      "version": "8.8.0",
      "resolved": "https://registry.npmjs.org/acorn/-/acorn-8.8.0.tgz",
@@ -6994,9 +6974,9 @@
      "dev": true
    },
    "bignumber.js": {
-      "version": "9.1.0",
-      "resolved": "https://registry.npmjs.org/bignumber.js/-/bignumber.js-9.1.0.tgz",
-      "integrity": "sha512-4LwHK4nfDOraBCtst+wOWIHbu1vhvAPJK8g8nROd4iuc3PSEjWif/qwbkh8jwCJz6yDBvtU4KPynETgrfh7y3A=="
+      "version": "9.1.1",
+      "resolved": "https://registry.npmjs.org/bignumber.js/-/bignumber.js-9.1.1.tgz",
+      "integrity": "sha512-pHm4LsMJ6lzgNGVfZHjMoO8sdoRhOzOH4MLmY65Jg70bpxCKu5iOHNJyfF6OyvYw7t8Fpf35RuzUyqnQsj8Vig=="
    },
    "brace-expansion": {
      "version": "1.1.11",
@@ -7457,11 +7437,6 @@
      "integrity": "sha512-kVscqXk4OCp68SZ0dkgEKVi6/8ij300KBWTJq32P/dYeWTSwK41WyTxalN1eRmA5Z9UU/LX9D7FWSmV9SAYx6g==",
      "dev": true
    },
-    "event-target-shim": {
-      "version": "5.0.1",
-      "resolved": "https://registry.npmjs.org/event-target-shim/-/event-target-shim-5.0.1.tgz",
-      "integrity": "sha512-i/2XbnSz/uxRCU6+NdVJgKWDTM427+MqYbkQzD321DuCQJUqOuJKIA0IM2+W2xtYHdKOmZ4dR6fExsd4SXL+WQ=="
-    },
    "execa": {
      "version": "5.1.1",
      "resolved": "https://registry.npmjs.org/execa/-/execa-5.1.1.tgz",
@@ -7638,11 +7613,10 @@
      "integrity": "sha512-yIovAzMX49sF8Yl58fSCWJ5svSLuaibPxXQJFLmBObTuCr0Mf1KiPopGM9NiFjiYBCbfaa2Fh6breQ6ANVTI0A=="
    },
    "gaxios": {
-      "version": "4.3.3",
-      "resolved": "https://registry.npmjs.org/gaxios/-/gaxios-4.3.3.tgz",
-      "integrity": "sha512-gSaYYIO1Y3wUtdfHmjDUZ8LWaxJQpiavzbF5Kq53akSzvmVg0RfyOcFDbO1KJ/KCGRFz2qG+lS81F0nkr7cRJA==",
+      "version": "5.0.2",
+      "resolved": "https://registry.npmjs.org/gaxios/-/gaxios-5.0.2.tgz",
+      "integrity": "sha512-TjtV2AJOZoMQqRYoy5eM8cCQogYwazWNYLQ72QB0kwa6vHHruYkGmhhyrlzbmgNHK1dNnuP2WSH81urfzyN2Og==",
      "requires": {
-        "abort-controller": "^3.0.0",
        "extend": "^3.0.2",
        "https-proxy-agent": "^5.0.0",
        "is-stream": "^2.0.0",
@@ -7650,11 +7624,11 @@
      }
    },
    "gcp-metadata": {
-      "version": "4.3.1",
-      "resolved": "https://registry.npmjs.org/gcp-metadata/-/gcp-metadata-4.3.1.tgz",
-      "integrity": "sha512-x850LS5N7V1F3UcV7PoupzGsyD6iVwTVvsh3tbXfkctZnBnjW5yu5z1/3k3SehF7TyoTIe78rJs02GMMy+LF+A==",
+      "version": "5.2.0",
+      "resolved": "https://registry.npmjs.org/gcp-metadata/-/gcp-metadata-5.2.0.tgz",
+      "integrity": "sha512-aFhhvvNycky2QyhG+dcfEdHBF0FRbYcf39s6WNHUDysKSrbJ5vuFbjydxBcmewtXeV248GP8dWT3ByPNxsyHCw==",
      "requires": {
-        "gaxios": "^4.0.0",
+        "gaxios": "^5.0.0",
        "json-bigint": "^1.0.0"
      }
    },
@@ -7671,9 +7645,9 @@
      "dev": true
    },
    "get-intrinsic": {
-      "version": "1.1.3",
-      "resolved": "https://registry.npmjs.org/get-intrinsic/-/get-intrinsic-1.1.3.tgz",
-      "integrity": "sha512-QJVz1Tj7MS099PevUG5jvnt9tSkXN8K14dxQlikJuPt4uD9hHAHjLyLBiLR5zELelBdD9QNRAXZzsJx0WaDL9A==",
+      "version": "1.2.0",
+      "resolved": "https://registry.npmjs.org/get-intrinsic/-/get-intrinsic-1.2.0.tgz",
+      "integrity": "sha512-L049y6nFOuom5wGyRc3/gdTLO94dySVKRACj1RmJZBQXlbTMhtNIgkWkUHq+jYmZvKf14EW1EoJnnjbmoHij0Q==",
      "requires": {
        "function-bind": "^1.1.1",
        "has": "^1.0.3",
@@ -7754,40 +7728,47 @@
      }
    },
    "google-auth-library": {
-      "version": "7.14.1",
-      "resolved": "https://registry.npmjs.org/google-auth-library/-/google-auth-library-7.14.1.tgz",
-      "integrity": "sha512-5Rk7iLNDFhFeBYc3s8l1CqzbEBcdhwR193RlD4vSNFajIcINKI8W8P0JLmBpwymHqqWbX34pJDQu39cSy/6RsA==",
+      "version": "8.7.0",
+      "resolved": "https://registry.npmjs.org/google-auth-library/-/google-auth-library-8.7.0.tgz",
+      "integrity": "sha512-1M0NG5VDIvJZEnstHbRdckLZESoJwguinwN8Dhae0j2ZKIQFIV63zxm6Fo6nM4xkgqUr2bbMtV5Dgo+Hy6oo0Q==",
      "requires": {
        "arrify": "^2.0.0",
        "base64-js": "^1.3.0",
        "ecdsa-sig-formatter": "^1.0.11",
        "fast-text-encoding": "^1.0.0",
-        "gaxios": "^4.0.0",
-        "gcp-metadata": "^4.2.0",
-        "gtoken": "^5.0.4",
+        "gaxios": "^5.0.0",
+        "gcp-metadata": "^5.0.0",
+        "gtoken": "^6.1.0",
        "jws": "^4.0.0",
        "lru-cache": "^6.0.0"
      }
    },
    "google-p12-pem": {
-      "version": "3.1.4",
-      "resolved": "https://registry.npmjs.org/google-p12-pem/-/google-p12-pem-3.1.4.tgz",
-      "integrity": "sha512-HHuHmkLgwjdmVRngf5+gSmpkyaRI6QmOg77J8tkNBHhNEI62sGHyw4/+UkgyZEI7h84NbWprXDJ+sa3xOYFvTg==",
+      "version": "4.0.1",
+      "resolved": "https://registry.npmjs.org/google-p12-pem/-/google-p12-pem-4.0.1.tgz",
+      "integrity": "sha512-WPkN4yGtz05WZ5EhtlxNDWPhC4JIic6G8ePitwUWy4l+XPVYec+a0j0Ts47PDtW59y3RwAhUd9/h9ZZ63px6RQ==",
      "requires": {
        "node-forge": "^1.3.1"
      }
    },
    "googleapis-common": {
-      "version": "5.1.0",
-      "resolved": "https://registry.npmjs.org/googleapis-common/-/googleapis-common-5.1.0.tgz",
-      "integrity": "sha512-RXrif+Gzhq1QAzfjxulbGvAY3FPj8zq/CYcvgjzDbaBNCD6bUl+86I7mUs4DKWHGruuK26ijjR/eDpWIDgNROA==",
+      "version": "6.0.4",
+      "resolved": "https://registry.npmjs.org/googleapis-common/-/googleapis-common-6.0.4.tgz",
+      "integrity": "sha512-m4ErxGE8unR1z0VajT6AYk3s6a9gIMM6EkDZfkPnES8joeOlEtFEJeF8IyZkb0tjPXkktUfYrE4b3Li1DNyOwA==",
      "requires": {
        "extend": "^3.0.2",
-        "gaxios": "^4.0.0",
-        "google-auth-library": "^7.14.0",
+        "gaxios": "^5.0.1",
+        "google-auth-library": "^8.0.2",
        "qs": "^6.7.0",
        "url-template": "^2.0.8",
-        "uuid": "^8.0.0"
+        "uuid": "^9.0.0"
+      },
+      "dependencies": {
+        "uuid": {
+          "version": "9.0.0",
+          "resolved": "https://registry.npmjs.org/uuid/-/uuid-9.0.0.tgz",
+          "integrity": "sha512-MXcSTerfPa4uqyzStbRoTgt5XIe3x5+42+q1sDuy3R5MDk66URdLMOZe5aPX/SQd+kuYAh0FdP/pO28IkQyTeg=="
+        }
      }
    },
    "graceful-fs": {
@@ -7803,12 +7784,12 @@
      "dev": true
    },
    "gtoken": {
-      "version": "5.3.2",
-      "resolved": "https://registry.npmjs.org/gtoken/-/gtoken-5.3.2.tgz",
-      "integrity": "sha512-gkvEKREW7dXWF8NV8pVrKfW7WqReAmjjkMBh6lNCCGOM4ucS0r0YyXXl0r/9Yj8wcW/32ISkfc8h5mPTDbtifQ==",
+      "version": "6.1.2",
+      "resolved": "https://registry.npmjs.org/gtoken/-/gtoken-6.1.2.tgz",
+      "integrity": "sha512-4ccGpzz7YAr7lxrT2neugmXQ3hP9ho2gcaityLVkiUecAiwiy60Ii8gRbZeOsXV19fYaRjgBSshs8kXw+NKCPQ==",
      "requires": {
-        "gaxios": "^4.0.0",
-        "google-p12-pem": "^3.1.3",
+        "gaxios": "^5.0.1",
+        "google-p12-pem": "^4.0.0",
        "jws": "^4.0.0"
      }
    },
@@ -8528,9 +8509,9 @@
      "dev": true
    },
    "json5": {
-      "version": "2.2.1",
-      "resolved": "https://registry.npmjs.org/json5/-/json5-2.2.1.tgz",
-      "integrity": "sha512-1hqLFMSrGHRHxav9q9gNjJ5EXznIxGVO09xQRrwplcS8qs28pZ8s8hupZAmqDwZUmVZ2Qb2jnyPOWcDH8m8dlA==",
+      "version": "2.2.3",
+      "resolved": "https://registry.npmjs.org/json5/-/json5-2.2.3.tgz",
+      "integrity": "sha512-XmOWe7eyHYH14cLdVPoyg+GOH3rYX++KpzrylJwSW98t3Nk+U8XOl8FWKOgwtzdb8lXGf6zYwDUzeHMWfxasyg==",
      "dev": true
    },
    "jsonfile": {
@@ -8821,9 +8802,9 @@
      }
    },
    "object-inspect": {
-      "version": "1.12.2",
-      "resolved": "https://registry.npmjs.org/object-inspect/-/object-inspect-1.12.2.tgz",
-      "integrity": "sha512-z+cPxW0QGUp0mcqcsgQyLVRDoXFQbXOwBaqyF7VIgI4TWNQsDHrBpUQslRmIfAoYWdYzs6UlKJtB2XJpTaNSpQ=="
+      "version": "1.12.3",
+      "resolved": "https://registry.npmjs.org/object-inspect/-/object-inspect-1.12.3.tgz",
+      "integrity": "sha512-geUvdk7c+eizMNUDkRpW1wJwgfOiOeHbxBR/hLXK1aT6zmVSO0jsQcs7fj6MGw89jC/cjGfLcNOrtMYtGqm81g=="
    },
    "once": {
      "version": "1.4.0",
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "upload-google-play",
-  "version": "1.0.19",
+  "version": "1.1.0",
  "private": true,
  "description": "Upload an Android release (.apk or .aab) to Google Play Console",
  "main": "lib/index.js",
@@ -21,7 +21,7 @@
  "license": "MIT",
  "dependencies": {
    "@actions/core": "^1.10.0",
-    "@googleapis/androidpublisher": "^3.0.0",
+    "@googleapis/androidpublisher": "^4.1.0",
    "fast-glob": "^3.2.12",
    "jszip": "^3.10.1"
  },
@@ -30,7 +30,7 @@
    "@types/node": "^18.11.4",
    "@typescript-eslint/eslint-plugin": "^5.40.1",
    "@typescript-eslint/parser": "^5.40.1",
-    "@vercel/ncc": "^0.34.0",
+    "@vercel/ncc": "^0.36.1",
    "eslint": "^8.26.0",
    "github-action-ts-run-api": "^2.2.2",
    "jest": "^29.2.1",
--- a/src/edits.ts
+++ b/src/edits.ts
@@ -75,17 +75,16 @@ export async function runUpload(
 }

 async function uploadToPlayStore(options: EditOptions, releaseFiles: string[]): Promise<string | void> {
+    const internalSharingDownloadUrls: string[] = []
+    
    // Check the 'track' for 'internalsharing', if so switch to a non-track api
    if (options.track === 'internalsharing') {
        core.debug("Track is Internal app sharing, switch to special upload api")
-        const downloadUrls: string[] = []
        for (const releaseFile of releaseFiles) {
            core.debug(`Uploading ${releaseFile}`);
            const url = await uploadInternalSharingRelease(options, releaseFile)
-            downloadUrls.push(url)
+            internalSharingDownloadUrls.push(url)
        }
-        core.setOutput("internalSharingDownloadUrls", downloadUrls);
-        core.exportVariable("INTERNAL_SHARING_DOWNLOAD_URLS", downloadUrls);
    } else {
        // Create a new Edit
        const appEditId = await getOrCreateEdit(options)
@@ -96,6 +95,14 @@ async function uploadToPlayStore(options: EditOptions, releaseFiles: string[]):
        // Upload artifacts to Google Play, and store their version codes
        const versionCodes = await uploadReleaseFiles(appEditId, options, releaseFiles)

+        // Infer the download URL from the version codes
+        for (const versionCode of versionCodes) {
+            const url = inferInternalSharingDownloadUrl(options.applicationId, versionCode);
+            core.setOutput("internalSharingDownloadUrl", url);
+            core.exportVariable("INTERNAL_SHARING_DOWNLOAD_URL", url);      
+            internalSharingDownloadUrls.push(url);
+        }
+
        // Add the uploaded artifacts to the Edit track
        await addReleasesToTrack(appEditId, options, versionCodes);

@@ -117,6 +124,9 @@ async function uploadToPlayStore(options: EditOptions, releaseFiles: string[]):
            return Promise.reject(res.status);
        }
    }
+
+    core.setOutput("internalSharingDownloadUrls", internalSharingDownloadUrls);
+    core.exportVariable("INTERNAL_SHARING_DOWNLOAD_URLS", internalSharingDownloadUrls);    
 }

 async function uploadInternalSharingRelease(options: EditOptions, releaseFile: string): Promise<string> {
@@ -398,3 +408,10 @@ async function uploadReleaseFiles(appEditId: string, options: EditOptions, relea

    return versionCodes
 }
+
+function inferInternalSharingDownloadUrl(
+  applicationId: string,
+  versionCode: number
+) {
+  return `https://play.google.com/apps/test/${applicationId}/${versionCode}`;
+}
--- a/src/main.ts
+++ b/src/main.ts
@@ -54,33 +54,33 @@ export async function run() {
        const validatedReleaseFiles: string[] = await validateReleaseFiles(releaseFiles ?? [releaseFile])

        if (whatsNewDir != undefined && whatsNewDir.length > 0 && !fs.existsSync(whatsNewDir)) {
-            core.setFailed(`Unable to find 'whatsnew' directory @ ${whatsNewDir}`);
-            return
+            core.warning(`Unable to find 'whatsnew' directory @ ${whatsNewDir}`);
        }

        if (mappingFile != undefined && mappingFile.length > 0 && !fs.existsSync(mappingFile)) {
-            core.setFailed(`Unable to find 'mappingFile' @ ${mappingFile}`);
-            return
+            core.warning(`Unable to find 'mappingFile' @ ${mappingFile}`);
        }

        if (debugSymbols != undefined && debugSymbols.length > 0 && !fs.existsSync(debugSymbols)) {
-            core.setFailed(`Unable to find 'debugSymbols' @ ${debugSymbols}`);
-            return
+            core.warning(`Unable to find 'debugSymbols' @ ${debugSymbols}`);
        }

-        await runUpload(
-            packageName,
-            track,
-            inAppUpdatePriorityInt,
-            userFractionFloat,
-            whatsNewDir,
-            mappingFile,
-            debugSymbols,
-            releaseName,
-            changesNotSentForReview,
-            existingEditId,
-            status,
-            validatedReleaseFiles
+        await withTimeout(
+            3.6e+6, // 60 minute timeout
+            runUpload(
+                packageName,
+                track,
+                inAppUpdatePriorityInt,
+                userFractionFloat,
+                whatsNewDir,
+                mappingFile,
+                debugSymbols,
+                releaseName,
+                changesNotSentForReview,
+                existingEditId,
+                status,
+                validatedReleaseFiles
+            )
        )
    } catch (error: unknown) {
        if (error instanceof Error) {
@@ -119,4 +119,11 @@ async function validateServiceAccountJson(serviceAccountJsonRaw: string | undefi
    }
 }

+async function withTimeout<T>(timeoutMillis: number, promise: Promise<T>): Promise<T> {
+    return Promise.race([
+        new Promise<never>((_, reject) => setTimeout(reject, timeoutMillis)),
+        promise
+    ])
+}
+
 void run();
Author	SHA1	Message	Date
Jack Boswell	9a5e7fcdd5	Add an upload timeout of 60 minutes (#171 ) * Add an upload timeout of 60 minutes * Remove now defunct tests	2023-02-10 22:59:20 +13:00
Sindre Moen	02c72d76fe	Remove status default from README (#164 ) * Remove status default from README * Default status to `completed`	2023-02-10 22:00:07 +13:00
Shi Chen	cd131e853c	feature: Add support for App Bundle Explorer's Internal app sharing link. (#166 ) Updated json5 dependency to patch vulnerability.	2023-01-13 16:55:12 +13:00
Saalihou Ndiaye	8a353d6e46	Add doc about packageName needing to exist first (#168 )	2023-01-13 15:31:31 +13:00
dependabot[bot]	d5cf6e9445	Bump json5 from 2.2.1 to 2.2.3 (#167 ) Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](https://github.com/json5/json5/compare/v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2023-01-13 15:25:47 +13:00
Ivan Milisavljevic	b9dc4464a6	Dont fail the action if optional files are not present on the dics (#162 )	2022-12-07 15:19:47 +13:00
Keisuke Yamaguchi	974d2d7566	Update userFraction reuqired to false in README (#157 ) * Update userFraction reuqired to false * Update userFraction to exclusive-exclusive and delete default value	2022-11-23 17:13:43 +13:00
Jack Boswell	536f822b60	Update release workflow (#155 )	2022-11-03 19:22:11 +13:00
Jack Boswell	d7e6e42414	fix: Bring back the default release status (#154 ) * Bring back the default release status * Create a test for the bare minimum inputs	2022-11-03 19:11:20 +13:00